fix: include complementary ARIA landmarks in auto-scoped snapshots#64
Merged
fix: include complementary ARIA landmarks in auto-scoped snapshots#64
Conversation
detectMainContent now captures adjacent aside and [role="complementary"] siblings when a main landmark is found, returning a virtual locator that concatenates all region snapshots. This surfaces sidebar content like repository stats without requiring manual scoping. Complementary regions are capped at 3 and failures are silently skipped.
Wrap complementary landmark detection in its own try-catch so failures return mainLocator instead of falling back to body. Parallelize ariaSnapshot calls using Promise.all. Add tests for compLocator.count() throwing and all-complementary-fail scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<aside>,[role="complementary"]) alongside<main>, capturing sidebar content like repository stats that was previously excludedariaSnapshot()from main and up to 3 complementary siblingsariaSnapshot()calls for complementary regions are parallelized viaPromise.allTest Plan
web-ctl.jsand test replicaRelated Issues
Closes #26